Add ansible-lint ci job

.gitlab-ci.yml

@@ -0,0 +1,12 @@
+---
+
+image: docker.io/yokogawa/ansible-lint@sha256:2603476e7f8c111bdf4a186d84a077c156bc3d12d07cc1c632adc9949d4f0b9d
+
+stages:
+  - test
+
+lint:
+  stage: test
+  script:
+    - ansible-galaxy install -r requirements.yml
+    - ansible-lint --force-color

roles/postfix/tasks/tables.yml

@@ -22,4 +22,5 @@
 - name: postmap additional lookup tables
   command: >-
     postmap /etc/postfix/{{ item.item.key }}
+  changed_when: yes
   loop: "{{ postfix_register_additional_lookup_tables.results }}"

roles/schleuder/tasks/install_schleuder.yml

@@ -38,85 +38,3 @@
   command:
     cmd: gem install schleuder
     creates: /var/lib/schleuder-web/schleuder-web
-    
-- name: fetch schleuder-webupstream
-  become: yes
-  become_user: schleuder-web
-  command:
-    cmd: git fetch origin
-    chdir: /var/lib/schleuder-web/schleuder-web
-
-- name: checkout requested schleuder-web version
-  become: yes
-  become_user: schleuder-web
-  command:
-    cmd: git checkout "{{ schleuder_web_commitish }}"
-    chdir: /var/lib/schleuder-web/schleuder-web
-
-- name: render /var/lib/schleuder-web/schleuder-web/config/schleuder-web.yml
-  template:
-    src: var/lib/schleuder-web/schleuder-web/config/schleuder-web.yml.j2
-    dest: /var/lib/schleuder-web/schleuder-web/config/schleuder-web.yml
-    owner: schleuder-web
-    group: root
-    mode: 0600
-  notify: systemctl restart schleuder-web
-
-- name: render /var/lib/schleuder-web/schleuder-web/config/database.yml
-  template:
-    src: var/lib/schleuder-web/schleuder-web/config/database.yml.j2
-    dest: /var/lib/schleuder-web/schleuder-web/config/database.yml
-    owner: schleuder-web
-    group: nogroup
-    mode: 0644
-
-- name: get schleuder api tls fingerprint
-  community.crypto.x509_certificate_info:
-    path: /etc/schleuder/schleuder-certificate.pem
-  register: schleuder_register_apicert_info
-
-- name: render /etc/default/schleuder-web
-  template:
-    src: etc/default/schleuder-web.j2
-    dest: /etc/default/schleuder-web
-    owner: root
-    group: root
-    mode: 0600
-  vars:
-    tls_fingerprint: "{{ schleuder_register_apicert_info.fingerprints.sha256 | replace(':', '') }}"
-  notify: systemctl restart schleuder-web
-
-- name: render systemd service unit
-  template:
-    src: etc/systemd/system/schleuder-web.service.j2
-    dest: /etc/systemd/system/schleuder-web.service
-    owner: root
-    group: root
-    mode: 0644
-  notify: systemctl daemon-reload
-
-- name: run bundle install ... this may take a few minutes
-  become: yes
-  become_user: schleuder-web
-  command:
-    cmd: /usr/bin/bundle install --path /var/lib/schleuder-web/.gem --without deployment
-    chdir: /var/lib/schleuder-web/schleuder-web
-
-- name: run bundle db setup
-  become: yes
-  become_user: schleuder-web
-  command:
-    cmd: /usr/bin/bundle exec rake db:setup
-    chdir: /var/lib/schleuder-web/schleuder-web
-    creates: /var/lib/schleuder-web/schleuder-web.sqlite3
-  environment:
-    RAILS_ENV: production
-
-- name: flush systemd daemon-reload
-  meta: flush_handlers
-
-- name: start and enable schleuder-web
-  service:
-    name: schleuder-web
-    state: started
-    enabled: true

roles/schleuder/tasks/install_web.yml

@@ -31,22 +31,24 @@
   become: yes
   become_user: schleuder-web
   command:
-    cmd: git clone https://0xacab.org/schleuder/schleuder-web /var/lib/schleuder-web/schleuder-web
+    cmd: git clone https://0xacab.org/schleuder/schleuder-web /var/lib/schleuder-web/schleuder-web  # noqa command-instead-of-module git module would reset working directory
     creates: /var/lib/schleuder-web/schleuder-web
     
-- name: fetch schleuder-webupstream
+- name: fetch schleuder-web upstream
   become: yes
   become_user: schleuder-web
   command:
-    cmd: git fetch origin
+    cmd: git fetch origin  # noqa command-instead-of-module
     chdir: /var/lib/schleuder-web/schleuder-web
+  changed_when: yes
 
 - name: checkout requested schleuder-web version
   become: yes
   become_user: schleuder-web
   command:
-    cmd: git checkout "{{ schleuder_web_commitish }}"
+    cmd: git checkout "{{ schleuder_web_commitish }}"  # noqa command-instead-of-module
     chdir: /var/lib/schleuder-web/schleuder-web
+  changed_when: yes
 
 - name: render /var/lib/schleuder-web/schleuder-web/config/schleuder-web.yml
   template:
@@ -96,6 +98,7 @@
   command:
     cmd: /usr/bin/bundle install --path /var/lib/schleuder-web/.gem --without deployment
     chdir: /var/lib/schleuder-web/schleuder-web
+  changed_when: yes
 
 - name: run bundle db setup
   become: yes