fix: semantic erros in argument_specs

galaxy.yml

@@ -7,7 +7,7 @@ namespace: s3lph
 name: nameserver
 
 # The version of the collection. Must be compatible with semantic versioning
-version: "0.4.1"
+version: "0.4.2"
 
 # The path to the Markdown (.md) readme file. This path is relative to the root of the collection
 readme: README.md

roles/knot/meta/argument_specs.yml

@@ -26,9 +26,10 @@ argument_specs:
         type: str
         default: https://deb.knot-dns.cz/knot/
       knot_repository_distribution:
-        description: Suite name (distribution codename) of the upstream repository.
+        description:
+          - Suite name (distribution codename) of the upstream repository.
+          - Defaults to the value of C(ansible_facts.distribution_release).
         type: str
-        default: "C(ansible_facts.distribution_release)"
 
       knot_server_rundir:
         description: Runtime directory where Knot should e.g. write its control socket to.
@@ -46,20 +47,20 @@ argument_specs:
         description:
           - Response to a C(id.server. CH TXT) or C(hostname.bind. CH TXT) query.
           - Set to an empty value to disable.
+          - Defaults to C(ansible_facts.hostname).
         type: str
-        default: "C(ansible_facts.hostname)"
       knot_server_nsid:
         description:
           - The RFC 5001 NSID to include in responses when requested by the resolver.
           - Set to an empty value to disable.
+          - Defaults to C(ansible_facts.hostname).
         type: str
-        default: "C(ansible_facts.hostname)"
       knot_server_version:
         description:
           - Response to a C(version.server. CH TXT) or C(version.bind. CH TXT) query.
           - Set to an empty value to disable.
+          - Defaults to C(ansible_facts.hostname).
         type: str
-        default: "C(ansible_facts.hostname)"
       knot_server_listen:
         description:
           - The list of interfaces to listen on.
@@ -203,7 +204,7 @@ argument_specs:
             with C(.) replaced by (_).
           - "Recommendation: Keep one file per zone in C(group_vars/nameservers/zones/zone_<zonename>.yml)."
         type: dict
-        required: true
+        required: false
         options:
           name:
             description: Fully qualified name of the zone, including the trailing C(.).
@@ -256,43 +257,41 @@ argument_specs:
                   - TTL (in seconds) of negative responses.
                 type: int
                 required: true
-              records:
+          records:
+            description:
+              - All the records in this zone go here.
+            type: list
+            elements: dict
+            options:
+              name:
                 description:
-                  - All the records in this zone go here.
+                  - Name of the record.
-                type: list
+                  - Records without a trailing C(.) are relative to the zone apex.
-                elements: dict
+                  - Use C(@) to refer to the zone apex itself.
-                options:
+                type: str
-                  name:
+                required: true
-                    description:
+              ttl:
-                      - Name of the record.
+                description:
-                      - Records without a trailing C(.) are relative to the zone apex.
+                  - TTL of this record.
-                      - Use C(@) to refer to the zone apex itself.
+                  - If omitted, defaults to the zone TTL set in the O(soa) section.
-                    type: str
+                type: int
-                    required: true
+              class:
-                  ttl:
+                description:
-                    description:
+                  - Class of this record.
-                      - TTL of this record.
+                  - If omitted, defaults to the class set in the O(soa) section.
-                      - If omitted, defaults to the zone TTL set in the O(soa) section.
+                type: str
-                    type: int
+              type:
-                    default: O(soa.ttl)
+                description: Type of the record, e.g. C(AAAA), C(A) or C(CNAME).
-                  class:
+                type: str
-                    description:
+                required: true
-                      - Class of this record.
+              value:
-                      - If omitted, defaults to the class set in the O(soa) section.
+                description:
-                    type: str
+                  - Value of the record.
-                    default: O(soa.class)
+                  - >-
-                  type:
+                    Length restrictions for TXT records apply. Subdivide them with single-quoted double quotes
-                    description: Type of the record, e.g. C(AAAA), C(A) or C(CNAME).
+                    e.g. C('"first part of the txt record " "second part of the txt record"')
-                    type: str
+                type: str
-                    required: true
+                required: true
-                  value:
-                    description:
-                      - Value of the record.
-                      - >-
-                        Length restrictions for TXT records apply. Subdivide them with single-quoted double quotes
-                        e.g. C('"first part of the txt record " "second part of the txt record"')
-                    type: str
-                    required: true
           masters:
             description:
               - Hostnames of servers which should act as a primary for this zone.
@@ -322,31 +321,24 @@ argument_specs:
           algorithm:
             description: Zone-specific override for O(knot_dnssec_policy_algorithm).
             type: str
-            default: O(knot_dnssec_policy_algorithm)
           ksk_size:
             description: Zone-specific override for O(knot_dnssec_policy_ksk_size).
             type: str
-            default: O(knot_dnssec_policy_ksk_size)
           zsk_size:
             description: Zone-specific override for O(knot_dnssec_policy_zsk_size).
             type: str
-            default: O(knot_dnssec_policy_zsk_size)
           ksk_lifetime:
             description: Zone-specific override for O(knot_dnssec_policy_ksk_lifetime).
             type: str
-            default: O(knot_dnssec_policy_ksk_lifetime)
           zsk_lifetime:
             description: Zone-specific override for O(knot_dnssec_policy_zsk_lifetime).
             type: str
-            default: O(knot_dnssec_policy_zsk_lifetime)
           propagation_delay:
             description: Zone-specific override for O(knot_dnssec_policy_propagation_delay).
             type: str
-            default: O(knot_dnssec_policy_propagation_delay)
           cds_cdnskey_publish:
             description: Zone-specific override for O(knot_dnssec_policy_cds_publish).
             type: str
-            default: O(knot_dnssec_policy_cds_publish)
           sign_on_secondary:
             description:
               - Whether Knot should sign this zone even if it is not the primary nameserver.