Fix: Fetch receipt_pref in list_users.

matemat/db/facade.py

@@ -86,15 +86,19 @@ class MatematDatabase(object):
         users: List[User] = []
         with self.db.transaction(exclusive=False) as c:
             for row in c.execute('''
-                SELECT user_id, username, email, is_admin, is_member, balance
+                SELECT user_id, username, email, is_admin, is_member, balance, receipt_pref
                 FROM users
                 WHERE touchkey IS NOT NULL OR NOT :must_have_touchkey
               ''', {
                 'must_have_touchkey': with_touchkey
             }):
                 # Decompose each row and put the values into a User object
-                user_id, username, email, is_admin, is_member, balance = row
+                user_id, username, email, is_admin, is_member, balance, receipt_p = row
-                users.append(User(user_id, username, balance, email, is_admin, is_member))
+                try:
+                    receipt_pref: ReceiptPreference = ReceiptPreference(receipt_p)
+                except ValueError:
+                    raise DatabaseConsistencyError(f'{receipt_p} is not a valid ReceiptPreference')
+                users.append(User(user_id, username, balance, email, is_admin, is_member, receipt_pref))
         return users
 
     def get_user(self, uid: int) -> User:

matemat/db/test/test_facade.py

@@ -58,7 +58,8 @@ class DatabaseTest(unittest.TestCase):
             testuser: User = db.create_user('testuser', 'supersecurepassword', 'testuser@example.com', True, True)
             db.change_touchkey(testuser, '', 'touchkey', verify_password=False)
             db.create_user('anothertestuser', 'otherpassword', 'anothertestuser@example.com', False, True)
-            db.create_user('yatu', 'igotapasswordtoo', 'yatu@example.com', False, False)
+            u = db.create_user('yatu', 'igotapasswordtoo', 'yatu@example.com', False, False)
+            db.change_user(u, agent=None, receipt_pref=ReceiptPreference.WEEKLY)
             users = db.list_users()
             users_with_touchkey = db.list_users(with_touchkey=True)
         self.assertEqual(3, len(users))
@@ -76,6 +77,7 @@ class DatabaseTest(unittest.TestCase):
                 self.assertEqual('yatu@example.com', user.email)
                 self.assertFalse(user.is_member)
                 self.assertFalse(user.is_admin)
+                self.assertEqual(ReceiptPreference.WEEKLY, user.receipt_pref)
             usercheck[user.id] = 1
         self.assertEqual(3, len(usercheck))
         self.assertEqual(1, len(users_with_touchkey))